Reverse entries in SourceLookUpProvider
#742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first one should shadow the second one. Because if 2 entries contain the same class name, the JDK classloader loads the first one.
kasiaMarek
approved these changes
Aug 7, 2024
|
Yes the CI is always failing on this runner for a reason that I don't understand. Probably I should mute them on this runner specifically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If 2 entries contain the same class name, the first class should shadow the second class, because that the one loaded by the JDK
ClassLoader.Conicidentally that should fix scalameta/metals#5807.